Fix incorrect usage of segment_size instead of segment_bitmask#76
Open
redawl wants to merge 1 commit intojclehner:masterfrom
Open
Fix incorrect usage of segment_size instead of segment_bitmask#76redawl wants to merge 1 commit intojclehner:masterfrom
redawl wants to merge 1 commit intojclehner:masterfrom
Conversation
Owner
|
Thanks. What I'm also noticing though is a discrepancy between the footer format described here, with I'll investigate that further. |
Contributor
Author
|
I've been taking a look at this. From the docs, the previous 2 bytes before the Using the example from the docs, this c code shows they are equivalent: int a = -1 * (int32_t)(0xfffffffc);
int b = -1 * (int16_t)(0xfffc);
printf("Are these equivalent? %d = %d\n", a, b);outputs: Are these equivalent? 4 = 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the docs for gwsettings had what I believe is a mistake in the explanation for how segment_bitmask is used in the firmware.